Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancel button for pin change #146

Merged

Conversation

EndNationStates
Copy link
Contributor

@EndNationStates EndNationStates commented May 7, 2021

Added a cancel button for 'Change device PIN' screen.
Moved the 'confirm' button in initial PIN screen to bottom of screen for consistency.
Disabled submit when no value is entered to prevent unnecessary failed PIN attempts.

Screenshot 2021-05-08 at 09 06 23

Screenshot 2021-05-08 at 09 13 13

Edit: Fixed element positions

Copy link
Collaborator

@stepansnigirev stepansnigirev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I left a few minor comments.

src/gui/screens/input.py Show resolved Hide resolved
src/gui/screens/input.py Outdated Show resolved Hide resolved
src/gui/screens/input.py Outdated Show resolved Hide resolved
src/keystore/ram.py Outdated Show resolved Hide resolved
EndNationStates and others added 4 commits May 9, 2021 14:41
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
@EndNationStates
Copy link
Contributor Author

Thanks for the feedback!

@stepansnigirev stepansnigirev merged commit 061b41d into cryptoadvance:master May 9, 2021
@stepansnigirev stepansnigirev mentioned this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants