-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple seeds #149
Multiple seeds #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of storing multiple keys on the device and SD card.
What do you think about combining the source selection and file selection screens in one? So we detect all files on SD and flash and display them under two sections - Internal flash
and SD card
? Something like this:
Deleting can be done in the same way, we could even mark the files that contain currently loaded seed somehow.
For SD card storage we could also combine Save to SD card
and Export to SD card
screens in the following way:
When the user clicks on Save to SD
he has three options:
- Save encrypted with device secret so only this device can read this file - here we use binary file with
specter<hexid>
pattern - Save as plain text - we save as
export-....txt
file - Save with password encryption - in this case we ask for the password, and create a password-protected
.7z
file (probably should be in another PR as we still need to work on7z
support.
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
Co-authored-by: Stepan Snigirev <snigirev.stepan@gmail.com>
I'm not sure about combining the What would be the benefit of exporting the key in a .7z file? My idea to save the file encrypted is to have some security while still being able to use it on a different specter (as opposed to using device secret). If we could use the .7z file on other hww, I can see the advantage. I'll merge the files available on SD and internal into one screen, that makes sense. Edit: My comment about the encrypted export makes no sense in this PR. That and the 7z encrypted export belong in a different PR. Please disregard :) I suggest that for now we maintain the export to SD as plain text and revisit this later together with the encryption. |
Adds support for managing multiple seeds on both internal storage as SD.