UX upgrades to new key screen and easier display of recovery phrase #157
Conversation
moneymanolis
commented
Jun 8, 2021
moneymanolis
commented
- Generate new key
- New word numbering, words from the BIP39 wordlist are now displayed from 1-2048 instead of 0-2047
- "Next button" replaced by a "done button" to make clear that there is no other step.
- Display of recovery phrase
- Thus far, the display of the recovery phrase was a bit hidden, moved it one level higher to the settings screen.
…1-2048 instead of 0-2047 + some typos fixed.
|
just to check using a smartcard with firmware v1.5.4 the show recovery phrase does not work. Might not be touched by this PR, but a good place to test / reproduce. |
src/keystore/ram.py
Outdated
| """Manage storage and display of the recovery phrase""" | ||
| # This class can only show mnemonic, can't save | ||
| await self.show_mnemonic() | ||
| # async def storage_menu(self): |
There was a problem hiding this comment.
So here you made storage_menu optional for the KeyStore class.
In this case it makes sense to check if keystore has storage_menu attribute and only then display corresponding button in Specter settings.
I think we should do the same with show_mnemonic function - potentially keystore object may not be able to display a mnemonic (i.e. when all crypto happens on the smartcard and the keys never leave it). Currently it's not the case but better to think about that in advance.
There was a problem hiding this comment.
Should all be addressed with bea5a4c
That's strange, I just checked both in simulator and with the real device and smartcard - I can get the recovery phrase displayed. Can you double-check? |
|
Managed to reproduce the problem, but needs more detail. If I switch the device on and generate a keys the words can be shown. The problem is only when loading the keys from the smartcard without generating keys beforehand. |
…into bip39-wordlist
…nd show_mnemonic are available to control display of respective buttons
| # wait for menu selection | ||
| menuitem = await self.gui.menu(buttons, last=(255, None), note="Firmware version %s" % get_version()) | ||
|
|
||
| # process the menu button: | ||
| # back button | ||
| if menuitem == 255: | ||
| return self.mainmenu | ||
| elif menuitem == 0: | ||
| elif menuitem == 1: |
There was a problem hiding this comment.
I just changed this to 1 to have a proper ordering (now: 1, 2, 3, 4, 5).
