add support for wallet creation from xpubs #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now whenever you go to the xpub screen you can save this key to SD card or create a new wallet using this key. If the key derivation follows bip84, bip49 rules DIY will recommend corresponding wallet type, but in principle you can go crazy and even use your multisig xpub in singlesig wallet (but you shouldn't...).
Also this PR adds cross-app communication that may be useful in the future development. Any app can now pretend to be a "host" and ask any other app to do something. All verification and confirmation rules still apply as for communication with the host.
Close #80
Next: add cosigners app that can store xpubs and derivations of your cosigners and assist in multisig wallet creation process. Creation of custom miniscript wallets is not supported in the GUI yet, but let me know if you want this.