Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support musl #16

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Support musl #16

merged 2 commits into from
Jul 20, 2020

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Jul 19, 2020 •
edited
Loading

Ref. #15 Tested in node:alpine and node (glibc:2.24).

cc @wanseob @alcuadrado

@wanseob
Copy link

wanseob commented Jul 19, 2020

@fanatid Thank you so much for the quick fix!!

@alcuadrado
Copy link

This looks good! I thought it was going to be more complex, but prebuildify-cross looks great!

@fanatid fanatid merged commit dfa5f60 into master Jul 20, 2020
@fanatid fanatid deleted the support-musl branch July 20, 2020 14:03
@alcuadrado alcuadrado mentioned this pull request Jul 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug node-gyp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanatid @wanseob @alcuadrado