Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viper version #9

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Update viper version #9

merged 1 commit into from
Jul 28, 2021

Conversation

Tibo-lg
Copy link
Contributor

@Tibo-lg Tibo-lg commented Jul 27, 2021

No description provided.

@Tibo-lg Tibo-lg marked this pull request as draft July 27, 2021 06:37
@Tibo-lg
Copy link
Contributor Author

Tibo-lg commented Jul 27, 2021

Seems we would need to update the go version to be able to properly update viper: spf13/viper#1161

The reason I wanted to update it is because it drags some vulnerable dependencies, not sure if a big deal or not though.

@Tibo-lg Tibo-lg marked this pull request as ready for review July 27, 2021 07:41
Copy link
Contributor

@prunelsigma prunelsigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tibo-lg Tibo-lg changed the base branch from chore/update-gin to develop July 28, 2021 01:06
@Tibo-lg Tibo-lg merged commit 1114400 into develop Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants