Feature/#88 improve backup strategy #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create backup if it does no exist * otherwise compare already existing backup file with masterkey * on io error or corrupt backup, _only_ log it (except reading masterkey file, then throw)
src/main/java/org/cryptomator/cryptofs/common/MasterkeyBackupHelper.java
Show resolved
Hide resolved
overheadhunter
approved these changes
Sep 25, 2020
|
Complexity decreasing per file
==============================
+ src/main/java/org/cryptomator/cryptofs/common/MasterkeyBackupHelper.java -1
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #88
The backup strategy is now altered by only throwing an exception, if the masterkey file cannot be read. All other errors (comparsion with backup file, corrupt backup file, etc) are only logged on
WARNlevel, but do not throw an exception.The thought behind it is, that the backup strategy is only a best-effort attempt and for an application it is more important getting access to encrypted data rather than having a backup.
Additionally the method is renamed to better show its functionality.