Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new market API #503

Closed
theoreticalbts opened this issue Jan 7, 2016 · 4 comments
Closed

Implement new market API #503

theoreticalbts opened this issue Jan 7, 2016 · 4 comments
Assignees
Milestone

Comments

@theoreticalbts
Copy link
Contributor

This ticket is for the new market API being implemented by @mvandeberg -- if you are @mvandeberg and/or @bytemaster please write some information about the specification, rationale, and design notes for these changes in this ticket.

@theoreticalbts theoreticalbts changed the title Implement new market maker API Implement new market API Jan 7, 2016
mvandeberg pushed a commit that referenced this issue Jan 7, 2016
@theoreticalbts
Copy link
Contributor Author

I've reformatted the commits which were previously floating in a now-dead version of the develop branch into a new commit by these commands:

git checkout origin/master -b 503-api-new-market-api
git checkout 4e80f7628df6092255ea600ffa6191e6a97d09a6 libraries/app/{api,database_api}.cpp libraries/app/include/graphene/app/database_api.hpp
git commit -m "Implement new market API #503" --author=Vandeberg
git rebase --whitespace=fix HEAD~1

NB, origin/master was 51c1058 at the time of this writing.

@mvandeberg
Copy link

These changes add a higher level and easier to use API for accessing public market information. The additions are based on the API used by Poloniex. See https://poloniex.com/support/api/ Public API Methods.

@xeroc
Copy link
Contributor

xeroc commented Jan 12, 2016

This sounds great. It will make the calls for
https://github.com/xeroc/python-graphenelib/blob/master/grapheneexchange/grapheneexchange.py
execute much faster. Currently, I need to maintain three connects (2 x witness, 1 x cli_wallet) to offer a poloniex-style python api

@theoreticalbts theoreticalbts added this to the next2 milestone Feb 2, 2016
@theoreticalbts
Copy link
Contributor Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants