Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.7 #6

Closed
wants to merge 113 commits into from
Closed

Bevy 0.7 #6

wants to merge 113 commits into from

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Apr 17, 2022

Updated to Bevy 0.7. Here are PRs which I used as a reference for update:

But it's a draft since I faced the upstream issue: bevyengine/bevy#4507
To make it work I need MaterialPipelineKey to have public fields as it was before (before it was a simple tuple). Should be fixed with bevyengine/bevy#4508

@sax
Copy link

sax commented Jul 1, 2022

I was investigating this repo and was unable to compile either the main branch or this branch. Looking at head of bevy itself, I see that a whole lot has changed recently. I was playing around with fixing the compilation errors against bevy head, and got as far as this: https://github.com/sax/bevy-hikari/tree/bevy-0.8. This does not compile yet, and I'm not sure I can get too much further without diving pretty deep into bevy's internals. Anyways, I offer it as a start, in case it's useful.

@Shatur
Copy link
Contributor Author

Shatur commented Jul 1, 2022

@cryscan have a 0.8 branch that uses a different mechanism, but it's not ready yet.

@sax
Copy link

sax commented Jul 2, 2022

@Shatur whatever you have is likely more correct than my version. I'm just getting into bevy, and see that even what I understand is rapidly changing. Hopefully what I did today is in some way useful to you.

@Shatur
Copy link
Contributor Author

Shatur commented Sep 18, 2022

Superseded by #8.

@Shatur Shatur closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants