Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend/exporter: Add a kind field to DefIdContents #1198

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Conversation

W95Psp
Copy link
Collaborator

@W95Psp W95Psp commented Dec 18, 2024

This PR fixes #1162: it is adding a DefKind on DefIdContents.

@W95Psp W95Psp marked this pull request as ready for review December 18, 2024 14:38
@W95Psp W95Psp force-pushed the add-fields-to-defid branch from 4420eb7 to b28e6ac Compare December 18, 2024 14:41
@W95Psp W95Psp requested a review from maximebuyse December 18, 2024 14:42
@W95Psp W95Psp changed the title Add a kind field to DefIdContents Frontend/exporter: Add a kind field to DefIdContents Dec 18, 2024
Copy link
Contributor

@maximebuyse maximebuyse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@W95Psp W95Psp added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit ee8e17b Dec 18, 2024
15 checks passed
@W95Psp W95Psp deleted the add-fields-to-defid branch December 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: add a DefKind on DefIdContents
2 participants