fix(backend) Filter Impl after adding comments. #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikbhargavan
approved these changes
Dec 24, 2024
Done |
maximebuyse
force-pushed
the
filter-fst-comments-interface-only
branch
from
58c86e7 to
bb0a959
Compare
Actually the test I added breaks the CI because it tests the running hax on unsupported rust code (where hax produces a result but with an exit code of 1). I think we should merge anyway, but it would be nice to be able to test what happens with unsupported code. I'll add a comment in #485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1202.
This avoids creating an fst file with only comments in it in fsti-only mode. The filtering of
Implelements is moved to after treating comments.