fix(exporter+engine): drop default parameters on traits #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR disable default parameters on traits, both in the engine and in the exporter, following the conversation in #310. Explanation (quoting my comment in code): > On use site, Rust always give us all the generic > parameters, no matter the defaultness. This information is > thus not so useful. At the same time, as discussed in > #310, extracting this > default type causes failures when querying Rust for trait > resolution. We thus decided to disable this feature. If > this default type information is useful to you, please > open an issue on https://github.com/hacspec/hax. Fixes #310
Nadrieril
approved these changes
Oct 2, 2024
|
Thanks, yeah, no worries, the rest is just dumb propagation;:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disable default parameters on traits, both in the engine and in the exporter, following the conversation in #310.
Explanation (quoting my comment in code):
Fixes #310