Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround in trait resolution for associated items #990

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Nadrieril
Copy link
Collaborator

Now that we thoroughly erase lifetimes in trait resolution, we shouldn't have any binder problems left.

Fixes #747

@Nadrieril
Copy link
Collaborator Author

Charon failure is because I had #747 as a failing test and it now passes :D

@Nadrieril Nadrieril requested a review from W95Psp October 11, 2024 14:58
Copy link
Collaborator

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, having erase_and_norm doing the right job really helps a lot 😅
Let's merge! :)

@W95Psp W95Psp added this pull request to the merge queue Oct 14, 2024
Merged via the queue into cryspen:main with commit 1ba7ce3 Oct 14, 2024
12 of 13 checks passed
@Nadrieril Nadrieril deleted the ty-alias branch October 14, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic: type parameter out of range when instantiating
2 participants