lib: implement std::error::Error for HpkeError #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful for Jetbrains IDE users (e.g. CLion).
This commit implements `std::error::Error`, and `std::fmt::Display` for `HpkeError`, matching the approach already used for `hpke_rs_crypto::Error`. This makes handling `HpkeError` as a generic `Error` easier in downstream crates.
|
@franziskuskiefer Would you be willing to publish a v0.1.2 release with this change? (Separate note: I think the repo is missing a tag for the existing v0.1.1 release from June. The last tag is v0.1.0 from Feb) |
|
Yes, I can certainly do that. But I want to bump the tls_codec dependency first, which needs to be released first. This will take a day or two, but then I'm releasing a new version here. |
|
Sounds good. Thank you :-) |
|
I released 0.1.2 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements
std::error::Error, andstd::fmt::DisplayforHpkeError, matching the approach already used forhpke_rs_crypto::Error. This makes handlingHpkeErroras a genericErroreasier in downstream crates. Hopefully I haven't overlooked a reason you explicitly chose not to do this initially.