CI: check no-std support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
requested changes
Nov 29, 2023
.github/workflows/rust.yml
Outdated
| toolchain: stable | ||
| target: thumbv7em-none-eabihf | ||
| default: true | ||
| - name: Fuzz Base w/ RustCrypto |
There was a problem hiding this comment.
looks like a c&p . How about something like this?
Suggested change
| - name: Fuzz Base w/ RustCrypto | |
| - name: Build no-std w/ RustCrypto |
There was a problem hiding this comment.
thanks for catching that
japaric
force-pushed
the
ci-no-std-support-check
branch
from
df96901
to
d8ea398
Compare
|
I've updated the PR to check that all the crates (minus the evercrypt one) have proper no-std support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the time being, this only checks that the
hpke-rs-cryptocrate is no-std compatible.this new CI job won't pass until #50 is merged