Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpke-rs-rust-crypto: make deterministic-prng enable the std feature #59

Merged

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Nov 28, 2023

I noticed that running cargo build --all-features from the rust_crypto_provider directory does not work unless the std feature of its hpke-rs-crypto dependency is enabled so this PR fixes that

this is not a problem when running cargo test from the root of the repo because hpke-rs enables both hpke-rs-rust-crypto/deterministic-prng and hpke-rs-crypto. would it be worthwhile to run cargo b --all-features from the rust_crypto_provider directory in CI?

@franziskuskiefer
Copy link
Member

would it be worthwhile to run cargo b --all-features from the rust_crypto_provider directory in CI?

Good point. Yes I think it would be worth doing that.

@franziskuskiefer franziskuskiefer merged commit 1ab14aa into cryspen:main Nov 30, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants