Refactored the code a little and added some more debug_asserts #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franziskuskiefer
approved these changes
Oct 19, 2023
franziskuskiefer
approved these changes
Oct 19, 2023
|
Looks good to me. We reviewed this on a call with Goutam. Many asserts to
go, but we can get this in.
…On Thu, Oct 19, 2023, 16:02 Franziskus Kiefer ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#115 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFUVSZCD6YHY5SU7JWBCJDYAEXIJAVCNFSM6AAAAAA6EOMGQ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBXHAZTKOBXGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
xvzcf
force-pushed
the
testing
branch
10 times, most recently
from
770aab3 to
b99cf99
Compare
This reverts commit 8082f4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.