-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull out libcrux::kem
into a standalone crate
#304
Conversation
So they can be used by hybrid KEMs in the `libcrux-kem` crate.
So they can be used in the `libcrux-kem` crate
So they can be accessed in the `libcrux-kem` crate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, generally looks good to me with a few nits.
I'm not sure about the tests for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm with a few nits.
Can we keep a version of the implementation notes PDF from the old kyber folder?
I put a copy in |
This PR pulls out the KEM module from
libcrux
into a standalone crate in the workspace.For now, I have changed visibility to
pub
of anypub (crate)
items the module depended on inlibcrux
andlibcrux-ml-kem
. I have not yet re-exported the standalone KEM API inlibcrux
to avoid cyclic dependency, since the standalone crate still depends on theecdh
module inlibcrux
.I've also changed the naming from Kyber to ML-KEM in the standalone crate.