-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature kyber
for Round 3 Kyber API
#327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to figure out how to make eurydice happy here. But I left some comments to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change C extraction should work again. Looks like eurydice prefers the trait bounds on the functions. Let's do that for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm. But we should also update the C code. And it looks like that extraction is broken again 😬
Also drop unused test feature in ml-kem crate
This PR fixes #325, by making available
kyber{512,768,1024}
modules with their ownencapsulate
anddecapsulate
behind thekyber
feature, in addition to the regular ML-KEM API.The differences in Kyber compared to ML-KEM are
c.f. FIPS 203 (Draft), section 1.3.
Further, the hybrid KEMs in
libcrux-kem
are now available in both variants as well.