Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-KEM] Merge verified code back to main #598

Merged
merged 101 commits into from
Dec 17, 2024
Merged

[ML-KEM] Merge verified code back to main #598

merged 101 commits into from
Dec 17, 2024

Conversation

karthikbhargavan
Copy link
Contributor

No description provided.

franziskuskiefer
franziskuskiefer reviewed Sep 24, 2024
View reviewed changes
.github/workflows/mlkem.yml Outdated Show resolved Hide resolved
fstar-helpers/README.md Outdated Show resolved Hide resolved
libcrux-intrinsics/src/arm64_extract.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/Cargo.toml Outdated Show resolved Hide resolved
libcrux-ml-kem/src/variant.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/src/vector/portable/serialize.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/src/vector/portable/serialize.rs Outdated Show resolved Hide resolved
libcrux-ml-kem/src/vector/portable/ntt.rs Show resolved Hide resolved
libcrux-ml-kem/src/vector/portable/ntt.rs Show resolved Hide resolved
libcrux-ml-kem/src/vector/portable/ntt.rs Outdated Show resolved Hide resolved
@franziskuskiefer franziskuskiefer changed the title Merge verified code back to main [ML-KEM] Merge verified code back to main Sep 30, 2024
@karthikbhargavan karthikbhargavan mentioned this pull request Oct 7, 2024
Closed
@franziskuskiefer franziskuskiefer linked an issue Oct 7, 2024 that may be closed by this pull request
Merge dev to main #613
Closed
@karthikbhargavan karthikbhargavan marked this pull request as ready for review November 8, 2024 07:28
mamonet and others added 19 commits December 10, 2024 11:31
@franziskuskiefer franziskuskiefer mentioned this pull request Dec 16, 2024
Merged
@karthikbhargavan
Copy link
Contributor Author

  • Are the changes in the ml-das extraction intentional?
  • We need a doc with the exact state of verification.

No, there should be no changes in ML-DSA, except if it had some unintentional references to ML-KEM.
Added a doc in proofs/verification_status.md

franziskuskiefer
franziskuskiefer approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this and and do anything that's open directly against main.

@karthikbhargavan karthikbhargavan added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit e7dca38 Dec 17, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keks keks keks left review comments

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@jschneider-bensch jschneider-bensch Awaiting requested review from jschneider-bensch

Assignees

@karthikbhargavan karthikbhargavan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge dev to main
5 participants
@karthikbhargavan @keks @franziskuskiefer @mamonet @W95Psp