Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export fixed-size versions of HPKE #690

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

keks
Copy link
Member

@keks keks commented Nov 18, 2024

Closes #419

@keks keks self-assigned this Nov 18, 2024
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just some nits about the docs.

libcrux-hkdf/src/impl_hacl.rs Outdated Show resolved Hide resolved
libcrux-hkdf/src/hkdf.rs Outdated Show resolved Hide resolved
libcrux-hkdf/src/hkdf.rs Outdated Show resolved Hide resolved
libcrux-hkdf/src/hkdf.rs Outdated Show resolved Hide resolved
@keks keks requested a review from a team as a code owner November 25, 2024 13:50
Copy link
Collaborator

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jschneider-bensch jschneider-bensch added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit b33f153 Nov 25, 2024
52 checks passed
@jschneider-bensch jschneider-bensch deleted the keks/hpke-fixed-size-419 branch November 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed sized APIs for HKDF
2 participants