Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update more of the spec to fips 203 #82

Merged
merged 12 commits into from
Sep 21, 2023
Merged

Update more of the spec to fips 203 #82

merged 12 commits into from
Sep 21, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Sep 19, 2023

No description provided.

franziskuskiefer
franziskuskiefer requested changes Sep 20, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is already pretty close.
I think we might be able to simplify even more.

specs/kyber/src/serialize.rs Outdated Show resolved Hide resolved
specs/hacspec-lib/src/bit_vector.rs Outdated Show resolved Hide resolved
specs/kyber/src/serialize.rs Show resolved Hide resolved
specs/kyber/src/sampling.rs Show resolved Hide resolved
specs/kyber/src/sampling.rs Show resolved Hide resolved
@xvzcf xvzcf merged commit 97fe462 into dev Sep 21, 2023
8 checks passed
@xvzcf xvzcf deleted the update-spec-to-fips-203 branch September 21, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer