Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inadvertently perform explicit rejection in Kyber. #95

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Don't inadvertently perform explicit rejection in Kyber. #95

merged 4 commits into from
Sep 28, 2023

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Sep 26, 2023

No description provided.

franziskuskiefer
franziskuskiefer requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing

src/kem/kyber768.rs Outdated Show resolved Hide resolved
src/kem/kyber768.rs Show resolved Hide resolved
@franziskuskiefer franziskuskiefer self-requested a review September 28, 2023 05:09
franziskuskiefer
franziskuskiefer approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@franziskuskiefer franziskuskiefer merged commit fdc4a1a into dev Sep 28, 2023
10 checks passed
@franziskuskiefer franziskuskiefer deleted the kyber-constant-time branch September 28, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer