Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with --release flag instead of --no-debug #47

Closed
wants to merge 1 commit into from
Closed

Build with --release flag instead of --no-debug #47

wants to merge 1 commit into from

Conversation

Sija
Copy link
Member

@Sija Sija commented Apr 13, 2018

@hugoabonizio
Copy link
Contributor

--release flag was removed in c5729b1#diff-b67911656ef5d18c4ae36cb6741b7965 (see #31)

The combination of --release --no-debug flags was required to avoid a compilation bug on Ubuntu (see crystal-lang/crystal#4719).

I think just removing --no-debug flag is fine.

@veelenga
Copy link
Member

veelenga commented Apr 13, 2018 •
edited
Loading

@hugoabonizio Is --no-debug still needed for lastest Crystal? I believe not, 'cause Travis is green.
@Sija Please remove --release.

@Sija Sija mentioned this pull request Apr 13, 2018
Merged
@Sija
Copy link
Member Author

Sija commented Apr 13, 2018

Done in #48.

@Sija Sija closed this Apr 13, 2018
@hugoabonizio
Copy link
Contributor

@veelenga IIRC this was fixed in version 0.24.1. It's not needed anymore at least on my Ubuntu 16.04 machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sija @hugoabonizio @veelenga