Add lint-scope config option
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
requested changes
Dec 4, 2024
Sija
reviewed
Dec 5, 2024
|
This PR became unwieldy, please split it into two: a bugfix one, and the new feature additions. |
nobodywasishere
force-pushed
the
nobody/lint-scope
branch
from
678f392 to
61778cc
Compare
|
Bug fixes moved to #157 |
…only on open files or the entire workspace Modify the ameba execute function to take either a workspace folder or a text document
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
nobodywasishere
force-pushed
the
nobody/lint-scope
branch
from
61778cc to
8a56ab8
Compare
|
This is ready for review. I have been using it consistently for the past month and it has worked well for me, from the Crystal compiler to Kagi's codebase, to other smaller projects. |
veelenga
reviewed
Jan 13, 2025
Sija
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tells ameba to either run only on open files or the entire workspace, and is useful for those who want to know what's happening across all files in the workspace instead of open ones.
This also adds a command for linting all files in the workspace, and fixes some minor bugs regarding handling virtual / untitled documents.