Add documentation for runtime tracing #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for crystal-book ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Blacksmoke16
reviewed
Jul 3, 2024
| $ crystal build -Dtracing hello-world.cr | ||
| $ CRYSTAL_TRACE=sched ./hello-world | ||
| sched.spawn 70569399740240 thread=0x7f48d7dc9740:? fiber=0x7f48d7cd0f00:main fiber=0x7f48d7cd0dc0:Signal Loop | ||
| sched.enqueue 70569399831716 thread=0x7f48d7dc9740:? fiber=0x7f48d7cd0f00:main fiber=0x7f48d7cd0dc0:Signal Loop duration=163 |
There was a problem hiding this comment.
I think it would be nice to expand upon the structure of the output. Like duration=163; what unit is that? Probably could do that as a follow up tho.
There was a problem hiding this comment.
Yes, we should, all times and durations are in nanoseconds!
There was a problem hiding this comment.
I second that it's missing what output to expect
There was a problem hiding this comment.
Especially since a 5 seconds sleep will print 5000000000 😱
beta-ziliani
reviewed
Jul 3, 2024
ysbaddaden
approved these changes
Jul 4, 2024
ysbaddaden
approved these changes
Jul 4, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature added in crystal-lang/crystal#14659
Resolves #766