Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen: fail to generate 'if' when one of the branches has no type #2

Closed
waj opened this issue Dec 10, 2012 · 1 comment
Closed

Codegen: fail to generate 'if' when one of the branches has no type #2

waj opened this issue Dec 10, 2012 · 1 comment

Comments

@waj
Copy link
Member

waj commented Dec 10, 2012 

def foo
end

if false
  foo
else
  1
end
@asterite
Copy link
Member

I think we should make empty functions and while loops have the Nil type, instead of void. Later we can optimize those functions to return void if they are not assigned to something.

@waj waj closed this as completed Dec 26, 2012
asterite pushed a commit that referenced this issue Feb 1, 2015
Try #2
6c97a3e
@Sija Sija mentioned this issue Aug 12, 2016
Closed
@Sija Sija mentioned this issue May 24, 2017
Closed
@straight-shoota straight-shoota mentioned this issue Aug 23, 2017
Closed
straight-shoota referenced this issue in straight-shoota/crystal Oct 15, 2017
@straight-shoota
# This is a combination of 3 commits.
f593f56 
# This is the 1st commit message:

Add formatter and parser for standards ISO8601, RFC1123, RFC2822

# The commit message #2 will be skipped:

# Prefer RFC 3339 instead of ISO 8601
#
# see https://stackoverflow.com/questions/522251/whats-the-difference-between-iso-8601-and-rfc-3339-date-formats and http://docs.diesel.rs/chrono/struct.DateTime.html#method.parse_from_rfc3339

# The commit message crystal-lang#3 will be skipped:

# Remove RFC 1123 in favour of RFC 2822
straight-shoota referenced this issue in straight-shoota/crystal Oct 15, 2017
@straight-shoota
# This is a combination of 3 commits.
4cf410d 
# This is the 1st commit message:

Add formatter and parser for standards ISO8601, RFC1123, RFC2822

# The commit message #2 will be skipped:

# Prefer RFC 3339 instead of ISO 8601
#
# see https://stackoverflow.com/questions/522251/whats-the-difference-between-iso-8601-and-rfc-3339-date-formats and http://docs.diesel.rs/chrono/struct.DateTime.html#method.parse_from_rfc3339

# The commit message crystal-lang#3 will be skipped:

# Remove RFC 1123 in favour of RFC 2822
@untied untied mentioned this issue Jul 29, 2018
Closed
@silmanduin66 silmanduin66 mentioned this issue Jan 10, 2019
Closed
@didactic-drunk didactic-drunk mentioned this issue Jul 2, 2019
Closed
oprypin pushed a commit to oprypin/crystal that referenced this issue Sep 9, 2019
@icyleaf
Merge pull request crystal-lang#2 from icyleaf/refactor-lexer-middlewave
5d5a9f1 
Refactor lexer middlewave
jan-zajic added a commit to jan-zajic/crystal that referenced this issue Nov 16, 2019
@jan-zajic
add missing documentation to String methods crystal-lang#2
55d5ea8
jan-zajic added a commit to jan-zajic/crystal that referenced this issue Jan 2, 2020
@jan-zajic
add missing documentation to String methods crystal-lang#2
c3473c4
jan-zajic added a commit to jan-zajic/crystal that referenced this issue Jan 2, 2020
@jan-zajic
add missing documentation to String methods crystal-lang#2
513c491
jan-zajic added a commit to jan-zajic/crystal that referenced this issue Jan 6, 2020
@jan-zajic
add missing documentation to String methods crystal-lang#2
edacfbb
jan-zajic added a commit to jan-zajic/crystal that referenced this issue Apr 8, 2020
@jan-zajic
add missing documentation to String methods crystal-lang#2
352373b
threez added a commit to threez/crystal that referenced this issue Jul 26, 2023
@threez
fixes incorrect require crystal-lang#2
1f9a1b8
@ysbaddaden ysbaddaden mentioned this issue Mar 25, 2024
Merged
@wolfgang371 wolfgang371 mentioned this issue Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waj @asterite