Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enum.from_value? for flag enum with non Int32 base type #10303

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Fix Enum.from_value? for flag enum with non Int32 base type #10303

merged 1 commit into from
Jan 28, 2021

Conversation

straight-shoota
Copy link
Member

Fixes #10301

I had even proposed this solution originally in #9883 (comment) but #10145 ended up using #to_i instead 🤦

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib labels Jan 26, 2021
@bcardiff bcardiff added the kind:regression Something that used to correctly work but no longer works label Jan 27, 2021
@asterite
Copy link
Member

I took the liberty of adding a kind:regression label so it's easier to track which things we'd want to include in a patch release.

@bcardiff bcardiff added this to the 1.0 milestone Jan 27, 2021
@asterite asterite modified the milestones: 1.0.0, 0.36.1 Jan 27, 2021
@bcardiff bcardiff merged commit d3833f2 into crystal-lang:master Jan 28, 2021
@straight-shoota straight-shoota deleted the fix/enum-flag-int branch January 28, 2021 17:46
bcardiff pushed a commit that referenced this pull request Jan 29, 2021
@straight-shoota @bcardiff
Fix Enum.from_value? for flag enum with non Int32 base type (#10303)
1a65b22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib
Projects
None yet
Milestone
0.36.1
Development

Successfully merging this pull request may close these issues.

Non Int32 Enum.from_value issue
3 participants
@straight-shoota @asterite @bcardiff