Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Int#chr reject surrogate halves #10451

Merged
merged 5 commits into from
Aug 24, 2021

Conversation

HertzDevil
Copy link
Contributor

Resolves #10440.

This completes my own review of the standard library's calls to Int#chr and #unsafe_chr. The result is:

src/int.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text labels Feb 27, 2021
@HertzDevil HertzDevil mentioned this pull request Jul 24, 2021
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@beta-ziliani beta-ziliani added this to the 1.2.0 milestone Aug 20, 2021
@straight-shoota straight-shoota merged commit 99768fb into crystal-lang:master Aug 24, 2021
@HertzDevil HertzDevil deleted the bug/int-chr-surrogate branch August 25, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surrogate halves
3 participants