Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct expectation to ensure set identifier #10482

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Correct expectation to ensure set identifier #10482

merged 1 commit into from
Mar 7, 2021

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 7, 2021

No description provided.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:collection labels Mar 7, 2021
sdogruyol
sdogruyol approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kachick 🙏

@sdogruyol sdogruyol merged commit 5878c87 into crystal-lang:master Mar 7, 2021
@kachick
Copy link
Contributor Author

kachick commented Mar 7, 2021

Thank you!

@kachick kachick deleted the fix-set-spec-correct-expectation branch March 7, 2021 14:56
@bcardiff bcardiff added this to the 1.0.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:collection
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kachick @straight-shoota @sdogruyol @bcardiff