Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type restrictions to HTTP-related classes #10586

Merged
merged 6 commits into from
Jun 7, 2021

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Apr 3, 2021

No description provided.

src/http/web_socket/protocol.cr Outdated Show resolved Hide resolved
@@ -18,11 +18,11 @@ class URI
@ptr = 0
end

def c
def c : UInt8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are internal APIs (see #10584 (comment))

src/http/cookie.cr Outdated Show resolved Hide resolved
@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 1, 2021
@straight-shoota straight-shoota merged commit 406afba into crystal-lang:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants