Refactor Socket::Addrinfo::Error
based on os_error
#10761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addrinfo::Error
used to have an extra ivarerror_code
to keep track of the error code. This patch refactors the class to useSystemError#os_error
and the associated factory methods instead, which is exactly made for this purpose.Addrinfo::Error
already inheritsSystemError
throughSocket::Error
, so this doesn't change the type hierarchy.As a result,
Addrinfo::Error#value
and theAddrinfo
constructors receiving a plainInt32
error code are being deprecated (they keep working as delegates to the respectiveSystemError
methods.A necessary addition to
SystemError
(first commit) is the factory method.os_error_message
which allows customization of the error message constructed from theos_error
value (which was previously hardcoded toos_error.message
). This allows incorporation ofopts
values into the message.