Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or revert some return type restrictions from #10575 #10857

Merged
merged 8 commits into from
Jul 3, 2021
Merged

Fix or revert some return type restrictions from #10575 #10857

merged 8 commits into from
Jul 3, 2021

Commits on Jun 28, 2021

  1. Fix return type restrictions crystal-lang#10588

    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    7331f5b View commit details
    Browse the repository at this point in the history

  2. Fix return type restrictions crystal-lang#10583

    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    334e49e View commit details
    Browse the repository at this point in the history

  3. Fix return type restriciton of Enumerable#minmax

    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    0cad8f7 View commit details
    Browse the repository at this point in the history

  4. Remove return type restriction on IO#read implementations 

    When it's not guaranteed that a wrapped IO returns `Int32`,
we can't use that restriction.
    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    b7a7cc2 View commit details
    Browse the repository at this point in the history

  5. Fix return type restriction of IO#skip implementations

    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    fa23fb5 View commit details
    Browse the repository at this point in the history

  6. Revert "Fix return type restriciton of Enumerable#minmax" 

    This reverts commit 0cad8f7.
    @straight-shoota
    straight-shoota committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    b998a9f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Re-introduce IO#read restrictions and cast to Int32

    @straight-shoota
    straight-shoota committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    e8cf88e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/return-type-restrictions

    @straight-shoota
    straight-shoota committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    68b9575 View commit details
    Browse the repository at this point in the history