Pass read-only flag to peeked slice in IO::Memory #10891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents potential segfaults or other unintended states caused by ignoring the read-protection of the inherited buffer in IO::Memory.
asterite
approved these changes
Jul 3, 2021
straight-shoota
approved these changes
Jul 3, 2021
straight-shoota
added
kind:bug
|
Thank you @z64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents potential segfaults or other unintended states caused by ignoring the read-protection of the inherited buffer in
IO::Memory.Reported by a user in Discord who was trying to re-use the buffer prior to
posas they were processing data frompeek/read. Unsure how common this kind of scenario is (specifically with ROM), but this seems like a sensible change for safety's sake.Unsure of the best way to organize the spec. Please feel free to move or change it.