Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use :nodoc: when overriding public methods #11096

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Don't use :nodoc: when overriding public methods #11096

merged 1 commit into from
Sep 24, 2021

Conversation

HertzDevil
Copy link
Contributor

sdogruyol
sdogruyol approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 🙏

@straight-shoota straight-shoota added this to the 1.2.0 milestone Sep 23, 2021
@straight-shoota straight-shoota merged commit 9e9da00 into crystal-lang:master Sep 24, 2021
@HertzDevil HertzDevil deleted the doc/nodoc-inherit branch September 25, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:docs topic:stdlib
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @straight-shoota @sdogruyol