Avoid needless union in LLVM::ABI::AArch64#homogeneous_aggregate?
#11199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
homog_aggended up being likeTuple(Type, Int32 | UInt64)?but usingUInt64all the time works.There's really no need to do this change, but... with this, the interpreter can process a lot more files. It's a bit of cheating, because the interpreter should support this, but right now I'm a bit lazy to implement that. I will! Eventually...
But with this change, for instance, the interpreter can already interpreter the compiler's formatter, and even doing something like
crystal i src/compiler/crystal.cr tool format foo.crworks 😮That said, it still takes a lot of time... doing the semantic analysis takes the same time, of course, but then producing bytecode, when there's a lot of code, takes a significant amount of time. It's less that what it takes to generate LLVM, but it's also not incredibly fast. Maybe there's still room for optimization!
(just to curb your enthusiasm, the interpreter might not be a fast alternative to compiled mode, but at least it will bring a repl and a debugger 🤷 )