Require right-hand side of one-to-many assignments to be Indexable
#11545
+143
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11414. The entire right-hand side needs to be an
Indexable
, not a union ofIndexable
and non-Indexable
types (maybe this could be relaxed like in #11145, but since the literal expander cannot decide whether the RHS can possibly be such a union, everyMultiAssign
will end up having a runtimeis_a?(::Indexable)
check).If
-Dstrict_multi_assign
is provided, the first assignment also produces the same compilation error.The first commit makes
Enumerable
andIndexable
built-in types. This does little other than making sure these modules exist even with an empty prelude; nothing else is done inCrystal::Program
(in particularIndexable
does not even includeEnumerable
there), and the standard library continues to be responsible for those additional definitions.