-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crash handler on Windows #11570
Merged
straight-shoota
merged 6 commits into
crystal-lang:master
from
HertzDevil:feature/windows-crash-handler
Jan 31, 2022
Merged
Add crash handler on Windows #11570
straight-shoota
merged 6 commits into
crystal-lang:master
from
HertzDevil:feature/windows-crash-handler
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
added
kind:feature
platform:windows
Windows support based on the MSVC toolchain / Win32 API
topic:stdlib:system
topic:stdlib:runtime
and removed
topic:stdlib:system
labels
Dec 11, 2021
Weird, the stack overflow spec works on my machine with the artifact... (the same spec even works on my fork's CI) |
straight-shoota
approved these changes
Dec 17, 2021
beta-ziliani
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Thanks! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind:feature
platform:windows
Windows support based on the MSVC toolchain / Win32 API
topic:stdlib:runtime
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches access violations and stack overflows using a vectored exception handler. This does not require a C shim.
Since the handler runs on the current thread without stack unwinding, we cannot print the backtrace on the same thread in the case of stack overflow. This PR creates a new thread directly through Win32, suspends the current thread, prints the backtrace on the new one, and then immediately terminates. This is probably fine since the program is dying anyway.Windows structured exceptions share some aspects with POSIX signals. This PR does not attempt to reconcile the two concepts in the standard library (see also #7339); it only picks these particular hardware exceptions because they are equivalent to SIGSEGV and provide useful feedback when dealing with unsafe code. Note that the two exceptions have distinct error codes, so things like #7482 shouldn't happen on Windows.
Example output: