Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeNode#private?, #public? and #visibility #11696

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

Hadeweka
Copy link
Contributor

@Hadeweka Hadeweka commented Jan 4, 2022

Adds the TypeNode#private? method to check for the visibility of classes and modules.

This is mostly relevant for cases in which a TypeNode is directly available (e.g. for iterating and resolving any public elements of TypeNode#ancestors).

Resolves #11705

@Hadeweka Hadeweka changed the title Add Typenode#private? Add TypeNode#private? Jan 4, 2022
@HertzDevil
Copy link
Contributor

Why #private? instead of #visibility?

@straight-shoota
Copy link
Member

Please let's start with an issue to discuss this feature first.

@Hadeweka Hadeweka reopened this Apr 4, 2024
@Hadeweka Hadeweka marked this pull request as ready for review April 4, 2024 09:35
ysbaddaden
ysbaddaden approved these changes Jun 10, 2024
@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 10, 2024
@straight-shoota straight-shoota changed the title Add TypeNode#private? Add TypeNode#private?, #public? and #visibility Jun 11, 2024
@straight-shoota straight-shoota merged commit c289f45 into crystal-lang:master Jun 11, 2024
59 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing option to determine visibility of TypeNode
5 participants