Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flush shift state for String#encode #11993

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Flush shift state for String#encode #11993

merged 3 commits into from
Jun 13, 2022

Conversation

HertzDevil
Copy link
Contributor

Fixes part of #11992.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text labels Apr 10, 2022
@HertzDevil
Copy link
Contributor Author

HertzDevil commented Apr 10, 2022 •
edited
Loading

According to here BIG5HKSCS should be supported by musl, but CI suggests otherwise. Why?

EDIT: It seems writing to BIG5HKSCS isn't supported, only decoding is, and I don't think any of the other supported encoders need a shift state.

sdogruyol
sdogruyol approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HertzDevil 🙏

@straight-shoota straight-shoota added this to the 1.5.0 milestone Jun 10, 2022
@straight-shoota straight-shoota merged commit d0b2b08 into crystal-lang:master Jun 13, 2022
@HertzDevil HertzDevil deleted the bug/string-encode-shift-state branch June 15, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:text
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HertzDevil @straight-shoota @sdogruyol