Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mutex on Windows #12213

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

HertzDevil
Copy link
Contributor

This enables the fiber-safe Mutex on Windows and removes the stub implementation. It is mostly unrelated to Thread::Mutex.

The standard library uses Mutex in Log::SyncDispatcher; it does not seem to break. (On the other hand, the specs for Log::AsyncDispatcher require non-blocking pipes, which are not available yet.)

Related: #5430

@HertzDevil HertzDevil added kind:feature topic:stdlib:concurrency platform:windows Windows support based on the MSVC toolchain / Win32 API labels Jul 6, 2022
@straight-shoota straight-shoota added this to the 1.6.0 milestone Jul 7, 2022
@straight-shoota straight-shoota merged commit c19df0b into crystal-lang:master Jul 15, 2022
@HertzDevil HertzDevil deleted the feature/win32-mutex branch July 15, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:concurrency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants