Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP::Client#exec to abort retry when client was closed #12465

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix HTTP::Client#exec to abort retry when client was closed #12465

merged 1 commit into from
Sep 22, 2022

Conversation

straight-shoota
Copy link
Member

Resolves #12464

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking kind:regression Something that used to correctly work but no longer works labels Sep 9, 2022
@beta-ziliani beta-ziliani added this to the 1.6.0 milestone Sep 21, 2022
@straight-shoota straight-shoota merged commit c3fddac into crystal-lang:master Sep 22, 2022
@straight-shoota straight-shoota deleted the fix/http-client-close branch September 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:networking
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

HTTP::Client#close has no effect when there's an active request
2 participants
@straight-shoota @beta-ziliani