Fix HTTP::Client implicit compression with retry
#12536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the retry mechanism in
HTTP::Client(which reconnects after a server hangup) forgetting whether the request had anAccept-Encodingheader. The client alters the request headers by adding its ownAccept-Encodingheader (if missing) and subsequently implicitly decompresses the response body.The fix is actually quite simple: The exec method needs to remember between the first send and the second (the retry) whether to use implicit compression.
Most of the changes are basically boilerplate to pass the information through to the nested methods.
Fixes #11354