Implement flock_* fiber-aware, without blocking the thread
#12728
Conversation
|
(changes are requested for the |
| raise IO::Error.from_errno("Error applying or removing file lock") | ||
| if retry | ||
| until flock(op) | ||
| ::Fiber.yield |
There was a problem hiding this comment.
If no other fibers have work to be done, what prevents this from spinning and using up 100% of the CPU until the file lock is obtained?
There was a problem hiding this comment.
Fair point. A sleep 5.milliseconds will significantly lower the pressure on the CPU in such scenario without blocking for too long.
There was a problem hiding this comment.
Yeah that's definitely not ideal. This is just a basic first step and we're missing other features like a timeout (as suggested in #12721 (comment)). Timeout and sleep are related, so might make sense to consider that together.
There was a problem hiding this comment.
Do we know when the timeout feature will be available in the crystal release for this function?
There was a problem hiding this comment.
Actually, I'm not sure about the timeout. Maybe that should rather be handled more generically.
We should definitely sleep the fiber, though. I've posted a patch for that in #12861.
Resolves #12721