Optimize Hash#select(Enumerable)
and #merge!(Hash, &)
#12737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two defs call
has_key?(k)
followed by[](k)
, performing a double lookup. This PR turns them intofind_entry(k)
.The optimization is quite noticeable when the keys are large structs, because their hash functions are more complex. I don't have a comprehensive benchmark but the speedup for
#select
is ~15% forUInt64
keys or ~60% forUInt8[128]
keys.