Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify expectation of loader spec error messages #12858

Merged

Conversation

straight-shoota
Copy link
Member

This is a follow-up on #12852 to simplify the error message expectation as suggested in #12852 (comment)

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @straight-shoota 🙏

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 10, 2023
@straight-shoota straight-shoota merged commit 55dc475 into crystal-lang:master Feb 11, 2023
@straight-shoota straight-shoota deleted the refactor/loader-spec branch February 11, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants