Fill docs for TupleLiteral
#12927
Merged
Fill docs for TupleLiteral
#12927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jan 10, 2023
Sija
reviewed
Jan 10, 2023
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
HertzDevil
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Perhaps we should also mention that some of these macro methods could produce empty TupleLiterals (e.g. select { false }) which, at this moment, are guaranteed to be a syntax error whenever interpolated.
Also, not exactly related to this PR, but TupleLiteral#[]='s error message still refers to ArrayLiteral.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though it's almost identical to
ArrayLiteral, we should still spell out the entire API ofTupleLiteralfor completeness. Also, it's not quite the same, there are some relevant differences.