Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added so char can be converted to int128 #12958

Merged
merged 6 commits into from
Jan 17, 2023
Merged

Added so char can be converted to int128 #12958

merged 6 commits into from
Jan 17, 2023

Conversation

meatball133
Copy link
Contributor

Resolves #12957

@straight-shoota
Copy link
Member

Probably should add u128 as well.

@Blacksmoke16
Copy link
Member

Prob wouldn't hurt to add some test cases similar to the other ones in spec/std/char_spec.cr too within the does to_i without a base example.

@beta-ziliani beta-ziliani added this to the 1.8.0 milestone Jan 16, 2023
@straight-shoota straight-shoota merged commit d772c72 into crystal-lang:master Jan 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Char can't be converted to in128
4 participants
@meatball133 @straight-shoota @Blacksmoke16 @beta-ziliani