Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename internal Iterator::Slice type to not conflict with ::Slice #12983

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Rename internal Iterator::Slice type to not conflict with ::Slice #12983

merged 3 commits into from
Feb 6, 2023

Conversation

Blacksmoke16
Copy link
Member

@straight-shoota
Copy link
Member

straight-shoota commented Jan 20, 2023 •
edited
Loading

I think we should do the same for all iterators defined in Iterator. Other iterators defined outside of Iterator have an "Iterator" suffix which should go a great way to make random name collisions unlikely.

@Blacksmoke16
Add Iterator suffix to other iterators
088ccde 
Normalize them all to be `private`
@straight-shoota
Copy link
Member

Failing specs need attention

@Blacksmoke16
Copy link
Member Author

Blacksmoke16 commented Jan 20, 2023 •
edited
Loading

Ogh well that's lovely. There is Iterator::Step and Steppable::StepIterator of which Steppable includes Iterator so now we have two StepIterators. Maybe they can be consolidated tho? I'll have to look into later today.

@Blacksmoke16
Copy link
Member Author

Blacksmoke16 commented Jan 21, 2023 •
edited
Loading

Okay so apparently Steppable::StepIterator is a public type so can't really rename that one. Imma just give the other internal one a diff name and call it a day.

@straight-shoota straight-shoota added this to the 1.8.0 milestone Feb 3, 2023
@straight-shoota straight-shoota merged commit a6353f8 into crystal-lang:master Feb 6, 2023
@Blacksmoke16 Blacksmoke16 deleted the rename-slice-iterator branch February 6, 2023 14:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib:collection
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Blacksmoke16 @straight-shoota @Sija