Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong default address when binding sockets #13006

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix wrong default address when binding sockets #13006

merged 3 commits into from
Feb 15, 2023

Commits on Jan 26, 2023

  1. Fix wrong default address when binding sockets

    @etra0
    etra0 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    ffababf View commit details
    Browse the repository at this point in the history

  2. Improve readability for sock.bind(port) and test. 

    Removed unused variable assignment in the unix socket test.
    @etra0
    etra0 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    6101f95 View commit details
    Browse the repository at this point in the history

  3. Fixed typo and default addresses. 

    Although the `address_and_port` is not used in `system_bind`, I think
it's important to display a correct error message, and so the IPv6 is
enclosed in square brackets [1] in case the exception is triggered

[1]: https://datatracker.ietf.org/doc/html/rfc2732#section-2
    @etra0
    etra0 committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c7e6783 View commit details
    Browse the repository at this point in the history